Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0010 | Add label: On-chain certification metadata #500

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

RSoulatIOHK
Copy link
Contributor

@RSoulatIOHK RSoulatIOHK commented Apr 7, 2023

Added transaction_metadatum_label 1304 to registry.json for the Certification metadata from CIP-???? | On-chain Certification Metadata Standard.

Added transaction_metadatum_label 1304 to registry.json for the Certification metadata from CIP-0123
@RSoulatIOHK RSoulatIOHK changed the title Update registry.json: Certification metadata Update registry.json in CIP-0010: Certification metadata Apr 7, 2023
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will obviously be needed for #499 although we have no CIP number for this standard yet.

@rphair rphair changed the title Update registry.json in CIP-0010: Certification metadata CIP-0010 | Add label: On-chain certification metadata Apr 7, 2023
@rphair rphair added the Update Adds content or significantly reworks an existing proposal label Apr 7, 2023
@rphair rphair added the CIP-0010: new registry entry Adding a new entry to the metadata label registry label Apr 12, 2023
@rphair
Copy link
Collaborator

rphair commented Aug 20, 2024

@Crypto2099 @Ryun1 this one I think slipped through the cracks in the editors' platform. Merge conflict is probably a matter of other metadata labels being added in the interim. @RSoulatIOHK you could also fix the merge conflict with a rebase of your branch I think & could get this OK'd more quickly... this is an issue I think now that we have requested attention on #499.

@rphair rphair requested review from Ryun1 and Crypto2099 August 20, 2024 02:50
@rphair
Copy link
Collaborator

rphair commented Aug 26, 2024

@RSoulatIOHK I've cleaned up the merge conflict by hand since I think we should put this through in advance to pave the way for

when you can get around to it (we need an update from you soon to keep that one open). @Crypto2099 @Ryun1 let's merge this to reserve the metadata tag number unless the candidate CIP-0096 authors indicate that their proposal has been deprecated.

@rphair rphair removed the Update Adds content or significantly reworks an existing proposal label Aug 26, 2024
@rphair rphair merged commit a1358fd into cardano-foundation:master Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIP-0010: new registry entry Adding a new entry to the metadata label registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants