-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0116 | Add Conway JSON schema #912
base: master
Are you sure you want to change the base?
Conversation
Minor fixes to schemas
Add examples for some types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing in response to ping from @nazrhom in #869 (comment) - I think I had expected @Ryun1 to yea or nea this one and then I think it fell through the cracks past all of us 😬 ... tagging Last Check
to ensure it doesn't evade us past the next CIP meeting (07 January), but also polling other editors for hopefully a review & merge before then.
Thanks @rphair I can't edit the original comment, but here is a list of changes in this PR:
|
List of changes in this PR (from #912 (comment)):
The corresponding tests are located at https://github.com/mlabs-haskell/cip-0116-tests