CIP-0105 | Add test vectors #952
Open
+247
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphair
added
Update
rphair
reviewed
Dec 21, 2024
There was a problem hiding this comment.
Thanks @paweljakubas and I apologise collectively for the last name spelling 😰
These updates look vital but the blank lines removed between the 2 key formats were essential to break those lines apart: without those, each set of adjacent lines runs into a single paragraph. You can see in your branch that "little" terms jump between lines, e.g. in https://github.com/paweljakubas/CIPs/blob/paweljakubas/cip-0105-more-test-vectors/CIP-0105/test-vectors/test-vector-1.md
Once those removed delimiting blank lines are restored I'd be happy to approve this, counting that @Ryun1 will vet the particulars though I also trust your own expertise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance to CIP-0129 missing data in all test vectors was added, mainly for credentials.
Also proper tags ("deprecated") where needed were added.
After the current PR is merged CIP-0105 will be thoroughly compliant with CIP-0129 from the point of view of test data