Fix network status peers #484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvieiro
force-pushed
the
fix/network-status-peers
branch
from
8381d10 to
792c0dd
Compare
jvieiro
force-pushed
the
fix/network-status-peers
branch
from
20d9fe1 to
22cdf67
Compare
jvieiro
force-pushed
the
fix/network-status-peers
branch
from
22cdf67 to
109091e
Compare
jvieiro
force-pushed
the
fix/network-status-peers
branch
from
0dcadab to
109091e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cardano-rosetta responds to the network query with the peer relay rather than the connected peers, which needs to be corrected to deliver on the intent of the API.
Proposed Solution
In lieu of a cardano-node API we should instead read the topology file to detect the port, and then query for connected peers.