feat: fix the addPolicy bug

casbin · Nov 26, 2024 · 183c8d7 · 183c8d7
1 parent 8dd4940
commit 183c8d7
Showing 1 changed file with 16 additions and 3 deletions.
diff --git a/src/main/java/org/casbin/jcasbin/model/Policy.java b/src/main/java/org/casbin/jcasbin/model/Policy.java
@@ -22,6 +22,9 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Arrays;
+
+import static org.casbin.jcasbin.util.Util.splitCommaDelimited;
 
 /**
  * Policy represents the whole access control policy user defined.
@@ -187,6 +190,16 @@ public boolean addPolicy(String sec, String ptype, List<String> rule) {
             List<List<String>> policy = assertion.policy;
             int priorityIndex = assertion.priorityIndex;
 
+            String line = ptype + "," + String.join(",", rule);
+            if ("".equals(line)) {
+                return false;
+            }
+            if (line.charAt(0) == '#') {
+                return false;
+            }
+            String[] tokens = splitCommaDelimited(line);
+            List<String> linePolicy = Arrays.asList(Arrays.copyOfRange(tokens, 1, tokens.length));
+
             // ensure the policies is ordered by priority value
             if ("p".equals(sec) && priorityIndex >= 0) {
                 int value = Integer.parseInt(rule.get(priorityIndex));
@@ -200,13 +213,13 @@ public boolean addPolicy(String sec, String ptype, List<String> rule) {
                         right = mid;
                     }
                 }
-                policy.add(left, rule);
+                policy.add(left, linePolicy);
                 for (int i = left; i < assertion.policy.size(); ++i) {
                     assertion.policyIndex.put(assertion.policy.get(i).toString(), i);
                 }
             } else {
-                policy.add(rule);
-                assertion.policyIndex.put(rule.toString(), policy.size() - 1);
+                policy.add(linePolicy);
+                assertion.policyIndex.put(linePolicy.toString(), policy.size() - 1);
             }
 
             return true;