Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 167: Adjust top Makefile dependency ordering in submodule initialization #168

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Issue 167: Adjust top Makefile dependency ordering in submodule initialization #168

merged 1 commit into from
Dec 19, 2024

Conversation

ajnelson-nist
Copy link
Member

@ajnelson-nist ajnelson-nist commented Nov 22, 2024 •
edited
Loading

This Pull Request resolves the bug described in #167 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is started in Draft status
  • CI passes in CASE feature branch against develop
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (d2e81b1)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora (N/A)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (N/A)

@ajnelson-nist
Adjust top Makefile dependency ordering in submodule initialization
a0a62e9 
References:
* #167

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist added the Project-Bug Something isn't working. label Nov 22, 2024
@ajnelson-nist ajnelson-nist added this to the CASE 1.4.0 milestone Nov 22, 2024
@ajnelson-nist ajnelson-nist linked an issue Nov 22, 2024 that may be closed by this pull request
Test workflow sometimes fails on parallelized initiation #167
Open
8 tasks
@ajnelson-nist ajnelson-nist mentioned this pull request Nov 22, 2024
Open
8 tasks
@ajnelson-nist ajnelson-nist marked this pull request as ready for review December 11, 2024 22:45
@ajnelson-nist
Copy link
Member Author

This PR is ready for review and merge.

@ajnelson-nist ajnelson-nist requested a review from a team December 11, 2024 22:47
@plbt5 plbt5 merged commit d380b87 into develop Dec 19, 2024
1 check passed
@plbt5 plbt5 deleted the BugFix-Issue-167 branch December 19, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
Project-Bug Something isn't working.
Projects
None yet
Milestone
CASE 1.4.0
Development

Successfully merging this pull request may close these issues.

Test workflow sometimes fails on parallelized initiation
2 participants
@ajnelson-nist @plbt5