-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder #143
Open
XKTZ
wants to merge
38
commits into
castorini:main
Choose a base branch
from
XKTZ:reorder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reorder #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itude rank_start and rank_end
…a permutation but now it is returning a string. Will need the cleanup pipeline in next step
ronakice
reviewed
Sep 16, 2024
README.md
Outdated
Comment on lines
206
to
207
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
ronakice
reviewed
Oct 19, 2024
src/rank_llm/scripts/run_rank_llm.py
Outdated
Comment on lines
167
to
171
"--step_size", | ||
type=int, | ||
default=10, | ||
help="step size for the sliding window approach", | ||
default=20, | ||
help="window size for the LLM", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
step and window are different?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Reference Issue
This is a superset of issue Top Down. This PR reorganized the various reordering methods including sliding window, top down, as well as ListT5's tournament sort methodology. Now it is allowed to use command like
--reorder_policy="top_down:{\"top_k\": 10, \"pivot\": ${PIVOT}, \"shuffle\": true, \"r\": 1}"
to specify a reorderer.ref:
Checklist Items
Before submitting your pull request, please review these items:
PR Type
What kind of change does this PR introduce?
Reproduce
Here is a small shell script helping to reproduce functionalities
File changes
rank_fid.py
,rank_gpt.py
,rank_listwise_os_llm.py
: They are now directly usinglistwise_rankllm.py
's rerank_batch function.listwise_rankllm.py
: the rerank batch deprecated the original method, usingModelFunction
to catch the necessary methods to doing rerank, and pass this into the reorder policies for reordering.reorder_policy.py
: various reorder policiestop_down/tournament...
: the implementation of different policiesxxx_reranker
: Add a parameter of reorder policy, defaultly using sliding windowrankllm.py
: Let create_prompt depends on select indices, instead of rangereranker.py
,run_rank_llm.py
: Parameter change