Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend/publish workflow #56

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Amend/publish workflow #56

merged 4 commits into from
Jul 7, 2023

Conversation

mentlak0
Copy link
Collaborator

@mentlak0 mentlak0 commented Jul 5, 2023

  • amend Github workflow to increment chart version before publish to GH pages.

@tomhobson tomhobson marked this pull request as ready for review July 6, 2023 09:19
@tomhobson
Copy link
Collaborator

failing?

@mentlak0
Copy link
Collaborator Author

mentlak0 commented Jul 6, 2023

@tomhobson looks like previous workflow that I created to increment on PR. Which is fine, because ive moved it to publish now

@mentlak0
Copy link
Collaborator Author

mentlak0 commented Jul 6, 2023

@tomhobson tested and the increment works correctly. Happy for you to review additional changes.

@tomhobson tomhobson merged commit 51e6784 into cdfoundation:main Jul 7, 2023
@tomhobson tomhobson deleted the amend/publish-workflow branch July 7, 2023 14:02
@mentlak0 mentlak0 mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhobson tomhobson tomhobson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mentlak0 @tomhobson