Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: amend node affinities to bring in default values #63

Conversation

mentlak0
Copy link
Collaborator

@mentlak0 mentlak0 commented Jul 24, 2023

  • amend makefile to load default affinities
  • amend patches and values.yaml to accommodate for the changes
  • manage remote-resolvers in the same way as webhook and controller deploy
  • increment chart version
  • clean up the values so consistent throughout

@mentlak0 mentlak0 force-pushed the amend/deploy-node-affinities branch from cd9399c to 10a0520 Compare July 24, 2023 19:51
Copy link
Collaborator

@msvticket msvticket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s mostly fine. I’m happy with the name changes, even though it might cause breakage for somebody…

But you seem to have missed copying the affinity for remoteresolver to values.yaml.

Also I prefer if you replace the find with explicit commands for the files (as I did). Otherwise if a new deployment is added upstreams affinities in that would be removed.

@mentlak0 mentlak0 requested a review from msvticket July 27, 2023 14:56
@msvticket msvticket merged commit 1c63604 into cdfoundation:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants