Add support of numpy2.0 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implicit signatures when there are default options are now deprecated in pyo3
Closed
ManonMarchand
force-pushed
the
maint-numpy2
branch
from
8100f1e to
99dd1f2
Compare
…opy mandatory dependency)
ManonMarchand
force-pushed
the
maint-numpy2
branch
from
f80d47c to
0f19457
Compare
|
todo: wait for cdshealpix-python v0.7.0 to be properly released |
…odifications for to_vec_raw deprecated in ndarray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping pyo3 and rust-numpy to v0.22 to add
support for python 3.13and numpy 2.0(Edit: support for python 3.13 cannot be provided, as pyerfa does not build on linux. They are working on it, there is just no new version out yet.)
Tested with numpy<2 and numpy>2 locally. The only differences for the users are the output of some displayed numbers.
Ex depths now appear as
numpy.uint8(0)instead of0. Otherwise, totally transparent.On the rust side: in pyo3, the implicit signatures of
pyfunctionsare now deprecated in case they have a parameter withOption<>.