Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Redis container from aborting randomly #405

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Fix Redis container from aborting randomly #405

merged 5 commits into from
Sep 13, 2024

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Sep 13, 2024

No description provided.

@Nusnus
Removed "--maxclients 100000" from Redis containers default CMD
892ab7a
@Nusnus
Fix Redis memory overcommit warning by adding Redis configuration opt…
7470092 
…ions

- Added --save "", --appendonly no, and --maxmemory-policy noeviction to Redis startup command
- Resolves the vm.overcommit_memory warning without using sysctl
@Nusnus Nusnus self-assigned this Sep 13, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 24.02%. Comparing base (b407343) to head (d6c58db).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
...rc/pytest_celery/vendors/redis/backend/fixtures.py 0.00% 1 Missing ⚠️
src/pytest_celery/vendors/redis/broker/fixtures.py 0.00% 1 Missing ⚠️
src/pytest_celery/vendors/redis/container.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   24.02%   24.02%           
=======================================
  Files          41       41           
  Lines        1286     1286           
  Branches      254      254           
=======================================
  Hits          309      309           
  Misses        949      949           
  Partials       28       28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nusnus
Fix Redis protected mode warning by disabling protected mode
a864d74 
Disabled Redis protected mode using the --protected-mode no option to
resolve the "Possible SECURITY ATTACK detected" warning during tests.
Protected mode is disabled because environments may trigger false positives
due to network interactions, causing Redis to exit unexpectedly.

This allows Redis to continue running without misinterpreting internal
connections as attacks.
@Nusnus Nusnus changed the title Resolves the vm.overcommit_memory warning during Redis container initialization Fix Redis container from aborting randomly Sep 13, 2024
@Nusnus Nusnus marked this pull request as ready for review September 13, 2024 12:47
@Nusnus Nusnus merged commit 6fb93a0 into celery:main Sep 13, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Nusnus Nusnus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nusnus