This repository has been archived by the owner on May 24, 2024. It is now read-only.
Add support for Node 14. #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenoworf
reviewed
Feb 4, 2022
| @@ -4,7 +4,7 @@ | |||
| "version": "1.52.2", | |||
| "description": "A framework to support application development with Terra components", | |||
| "engines": { | |||
| "node": ">=8.9.2 <15" | |||
| "node": "^8.9.2 || ^10.13.0 || ^12.0.0 || ^14.0.0" | |||
There was a problem hiding this comment.
Four versions seems a bit much. We are supporting three versions in other places - why not make it easy on ourselves and drop 8.0. Node 8 is circa 2017.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks. This motivates me to continue crafting a deprecation policy.
xenoworf
approved these changes
Feb 4, 2022
sdadn
approved these changes
Feb 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #140
Deployment Link
https://terra-applic-.herokuapp.com/
Testing
Additional Details
Thank you for contributing to Terra.
@cerner/terra