[clinical-result] Add doc example for header/cell #877
Conversation
|
Terra site for these changes: https://engineering.cerner.com/terra-clinical/pull/877 |
|
Have a WDIO issue I'm looking into for flowsheet result cell semantic table, discussing that on this PR here: #881 (comment) Other than that this can be looked at though. |
|
@RayGunY There is a WDIO test failing. Is it related to your changes? |
@vinaybhargavar Kind of, I'm working on it right now - it's being fixed in the defect PR. It's a lot to explain, so a breakdown can be found in this comment: #881 (comment) Basically the code on my side is correct and if you go look at the flowsheet semantic table test on the PR site you'll see it looks the way we want it to. The snapshot is failing here because I haven't pushed out the re-generated snapshot. You can ignore that failure for now and take a look at the rest of the code. Edit: removing that test from the flowsheet-result-cell-spec.js file so it doesn't generate wdio. We're taking care of that in this defect PR: #881 Since it's causing this PR to be put on hold we're removing it so it doesn't block this. |
|
Looks good, +1 after resolving the WDIO issue. |
Sounds good. +1 after resolving the WDIO issue. |
| @@ -1,4 +1,4 @@ | |||
| import React, { useRef, useState, useEffect } from 'react'; | |||
| import React, { useRef, useState, useLayoutEffect } from 'react'; | |||
There was a problem hiding this comment.
Fixes in this file are related to the flicker defect being dealt with in this PR: #881
Adding them to this PR because otherwise we'll have the same issue. Same things with the flowsheet css file.
|
@scottwilmarth @sdadn @sycombs This PR is good to be looked at. It's touching some of the same stuff as the defect PR so there is some overlap you might see. Trying to unblock this PR so we can wrap up clincial result phase 1, so the failing wdio test has been removed as that will technically be added in the defect PR. Defect PR for reference: #881 |
Summary
What was changed:
We need to add examples for clinical result of the usage for Flowsheet Cell, Time Header Cell, and Name Header Cell within a semantic html table.
I added a semantic table example instead of changing all of the existing examples in case consuming teams continue to use this component in a non-semantic way. We of course want our users to use this with appropriate semantic html, so I will be adding guidance on that in our accessibility page that is being created in another PR.
Why it was changed:
The look/behavior of these cells are different when they are used within semantic html tables, so we need to give examples of what that will look like.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9205
Thank you for contributing to Terra.
@cerner/terra