Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

[terra-clinical-detail-view] Added terra-clinical-detail-view accessibility guide #878

Merged
merged 10 commits into from
Jul 7, 2023
Merged

[terra-clinical-detail-view] Added terra-clinical-detail-view accessibility guide #878

merged 10 commits into from
Jul 7, 2023

Conversation

vinaybhargavar
Copy link
Contributor

@vinaybhargavar vinaybhargavar commented Jun 28, 2023 •
edited
Loading

Summary

Added terra-clinical-detail-view accessibility guide

What was changed:

Why it was changed:

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-8571

Thank you for contributing to Terra.
@cerner/terra

@vinaybhargavar vinaybhargavar self-assigned this Jun 28, 2023
@vinaybhargavar
Copy link
Contributor Author

Deployed site - https://engineering.cerner.com/terra-clinical/pull/878

@vinaybhargavar vinaybhargavar marked this pull request as ready for review June 28, 2023 00:28
aalexanderj
aalexanderj reviewed Jul 5, 2023
View reviewed changes
...linical-detail-view/src/terra-dev-site/doc/clinical-detail-view/AccessibilityGuide.2.doc.mdx Outdated Show resolved Hide resolved
...linical-detail-view/src/terra-dev-site/doc/clinical-detail-view/AccessibilityGuide.2.doc.mdx Outdated Show resolved Hide resolved
...linical-detail-view/src/terra-dev-site/doc/clinical-detail-view/AccessibilityGuide.2.doc.mdx Outdated Show resolved Hide resolved
...linical-detail-view/src/terra-dev-site/doc/clinical-detail-view/AccessibilityGuide.2.doc.mdx Show resolved Hide resolved
...linical-detail-view/src/terra-dev-site/doc/clinical-detail-view/AccessibilityGuide.2.doc.mdx Outdated Show resolved Hide resolved
...linical-detail-view/src/terra-dev-site/doc/clinical-detail-view/AccessibilityGuide.2.doc.mdx Show resolved Hide resolved
@scottwilmarth
Copy link

Looks great @vinaybhargavar! Thanks for your hard work.

@vinaybhargavar
Copy link
Contributor Author

@sdadn, @sycombs - This PR is ready for your review. Thanks.

@vinaybhargavar @sdadn
PR update
687a94f 
Co-authored-by: Saad Adnan <38024451+sdadn@users.noreply.github.com>
@vinaybhargavar @sdadn
PR updates
dd31f0b 
Co-authored-by: Saad Adnan <38024451+sdadn@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to preview-pr-878 July 7, 2023 20:36 Destroyed
@sdadn sdadn merged commit d238bdd into main Jul 7, 2023
21 checks passed
@sdadn sdadn deleted the UXPLATFORM-9094 branch July 7, 2023 21:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scottwilmarth scottwilmarth scottwilmarth approved these changes

@aalexanderj aalexanderj aalexanderj approved these changes

@sdadn sdadn sdadn approved these changes

@RayGunY RayGunY RayGunY approved these changes

@sycombs sycombs sycombs approved these changes

@brooksienoodlesoup brooksienoodlesoup Awaiting requested review from brooksienoodlesoup

@krycunn krycunn Awaiting requested review from krycunn

Assignees

@vinaybhargavar vinaybhargavar

Labels
📦 terra-clinical-detail-view ⭐ Accessibility Reviewed ⭐ UX Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vinaybhargavar @scottwilmarth @brooksienoodlesoup @aalexanderj @sdadn @RayGunY @sycombs