-
Notifications
You must be signed in to change notification settings - Fork 50
[terra-clinical-item-view] Fix for null item displays #924
Conversation
Based on the referenced defect, it sounds like the issue seen by the consumer is around |
@smason0 omg really good catch, for some reason I assumed based on the description in the Jira but didn't realize the code snippet was pointing to that. I added the check in this commit c861937#diff-a09eb4a886b729c86a83daac740d9a14a92e66fe733a7a907899150b7fdae956 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 with passing build
Summary
What was changed:
displays
prop is passed in, added check (didn't use ? here for readability)displays
contains a null item display in the array and a check was added as wellWhy it was changed:
displays
prop and get an error with the latest changesTesting
This change was tested using:
Before:
After:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9711
Thank you for contributing to Terra.
@cerner/terra