Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

renamed year select min-width css variable #942

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

adoroshk
Copy link
Contributor

Summary

It has been reported, that the value of the --terra-clinical-onset-picker-year-select-min-width variable in fusion theme is can be overridden by the same name variable coming from deprecated orion-fusion-theme package, which sometimes appears as dependency in some projects. To avoid that, the variable was renamed to --terra-clinical-onset-picker**-calendar**-year-select-min-width.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

The new variable being populated instead of the old one:
Screenshot 2024-04-11 at 2 25 27 PM

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10364

@github-actions github-actions bot temporarily deployed to preview-pr-942 April 11, 2024 18:37 Destroyed
@adoroshk adoroshk self-assigned this Apr 11, 2024
@cm9361
Copy link

cm9361 commented Apr 11, 2024

Just a question, why can't they remove the orion-fusion-theme package dependency?

@adoroshk
Copy link
Contributor Author

adoroshk commented Apr 11, 2024

Just a question, why can't they remove the orion-fusion-theme package dependency

Per request in the UXPLATFORM-10364 that would be change in one place, which is preferable to chasing multiple teams and waiting on their release schedule.

cc: @cm9361

@cm9361
Copy link

cm9361 commented Apr 11, 2024

Just a question, why can't they remove the orion-fusion-theme package dependency

Per request in the UXPLATFORM-10364 that would be change in one place, which is preferable to chasing multiple teams and waiting on their release schedule.

Understood. How do we ensure that there are not other conflicts? I would want to make sure that we are not making a bunch of one-off variable changes to avoid removing an outdated dependency moving forward.

@adoroshk
Copy link
Contributor Author

adoroshk commented Apr 11, 2024

Just a question, why can't they remove the orion-fusion-theme package dependency

Per request in the UXPLATFORM-10364 that would be change in one place, which is preferable to chasing multiple teams and waiting on their release schedule.

Understood. How do we ensure that there are not other conflicts? I would want to make sure that we are not making a bunch of one-off variable changes to avoid removing an outdated dependency moving forward.

In terra the variable is used in 3 files only. Its has been renamed in all 3 cases. I don't expect any complications in this specific case.

UPD: Also Heather Boege did a lot of testing on her side to ensure that once the correct value (which is 6em) for the fusion theme is populated, the year picker in power chart has enough space to not truncate the year.

@adoroshk adoroshk merged commit e0f3df2 into main Apr 11, 2024
22 checks passed
@adoroshk adoroshk deleted the onset-picker-year-css-var-renaming branch April 11, 2024 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants