Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Commit

Permalink
Review updates
Browse files Browse the repository at this point in the history
  • Loading branch information
arcw76183450 committed Jun 27, 2023
1 parent f9ece9d commit b1483ae
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
7 changes: 3 additions & 4 deletions packages/terra-content-container/src/ContentContainer.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ const propTypes = {
setFocusOnContainer: PropTypes.bool,
/**
* ![IMPORTANT](https://badgen.net/badge/UX/Accessibility/blue)
* This prop needs to be set only if `setFocusOnContainer` is set. Based on dark or light background color the border will be wite or black to match color contrast ratio
* guidelines.
* This prop needs to be set only if `setFocusOnContainer` is set. Based on dark or light background color the border will be white or black respectively to maintain

Check failure on line 38 in packages/terra-content-container/src/ContentContainer.jsx

View workflow job for this annotation

GitHub Actions / build

Trailing spaces not allowed
* an accessible color contrast ratio.
*/
backgroundColor: PropTypes.oneOf(['dark', 'light']),
};
Expand Down Expand Up @@ -73,8 +73,7 @@ const ContentContainer = ({
'normalizer',
theme.className,
{ 'content-container-focused-padding': setFocusOnContainer },
{ dark: background === 'dark' },
{ light: background === 'light' },
background

Check failure on line 76 in packages/terra-content-container/src/ContentContainer.jsx

View workflow job for this annotation

GitHub Actions / build

Missing trailing comma
);

return (
Expand Down
2 changes: 1 addition & 1 deletion packages/terra-scroll/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Added
* Added styles when the scroll is focussed
* Changed
* Removed the focus style changes added for terra-scroll.
* Reverted the focus style changes added in terra-scroll.

## 2.34.0 - (February 15, 2023)

Expand Down

0 comments on commit b1483ae

Please sign in to comment.