Fix infinite padding on multiple unload/load where maximum datapoint is zero

packages/carbon-graphs/CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 * Fixed
+  * Fixed infinite padding in line graphs on multiple unload/load where maximum datapoint is zero.
   * Fixed tick lines overflowing outside the grid container when using custom tick values.
 
 * Changed

packages/carbon-graphs/dev-site/serve/serve-static.js

@@ -1,6 +1,6 @@
+const fs = require('fs');
 const express = require('express');
 const rateLimit = require('express-rate-limit');
-const fs = require('fs');
 
 const displayServer = (localAddress) => {
   console.log('[serve-static] Server started listening at');

packages/carbon-graphs/src/js/helpers/axis.js

@@ -1593,7 +1593,7 @@ const getAxesDataRange = (
   const prevMax = config.axis[axis].dataRange.oldMax;
   let isRangeModified;
 
-  if (prevMin === 0) {
+  if (prevMin === 0 || prevMax === 0) {
     isRangeModified = !(prevMin <= curRange.min || prevMax >= curRange.max);
   } else {
     isRangeModified = !(prevMin && prevMax)

packages/carbon-graphs/tests/unit/controls/Line/LinePanning-spec.js

@@ -430,24 +430,47 @@ describe('Line - Panning', () => {
       });
     });
     describe('when the same data is passed on multiple clicks of panning', () => {
-      it('Range modified should be false', () => {
-        const panData = {
-          key: 'uid_1',
-          values: [
-            {
-              x: '2016-03-03T12:00:00Z',
-              y: 0,
-            },
-            {
-              x: '2016-04-03T12:00:00Z',
-              y: 20,
-            },
-          ],
-        };
-        graphDefault.reflow(panData);
-        graphDefault.reflow(panData);
-        graphDefault.reflow(panData);
-        expect(graphDefault.config.axis.y.dataRange.isRangeModified).toEqual(false);
+      describe('when Minimum Datapoint is 0', () => {
+        it('Range modified should be false', () => {
+          const panData = {
+            key: 'uid_1',
+            values: [
+              {
+                x: '2016-03-03T12:00:00Z',
+                y: 0,
+              },
+              {
+                x: '2016-04-03T12:00:00Z',
+                y: 20,
+              },
+            ],
+          };
+          graphDefault.reflow(panData);
+          graphDefault.reflow(panData);
+          graphDefault.reflow(panData);
+          expect(graphDefault.config.axis.y.dataRange.isRangeModified).toEqual(false);
+        });
+      });
+      describe('when Maximum Datapoint is 0', () => {
+        it('Range modified should be false', () => {
+          const panData = {
+            key: 'uid_1',
+            values: [
+              {
+                x: '2016-03-03T12:00:00Z',
+                y: 0,
+              },
+              {
+                x: '2016-04-03T12:00:00Z',
+                y: -20,
+              },
+            ],
+          };
+          graphDefault.reflow(panData);
+          graphDefault.reflow(panData);
+          graphDefault.reflow(panData);
+          expect(graphDefault.config.axis.y.dataRange.isRangeModified).toEqual(false);
+        });
       });
     });
   });

packages/carbon-graphs/webpack/dev-server.js

@@ -1,5 +1,5 @@
-const WebpackDevServer = require('webpack-dev-server');
 const path = require('path');
+const WebpackDevServer = require('webpack-dev-server');
 const webpack = require('webpack');
 const { jsOptions, cssOptions } = require('./helpers/rules');
 

webpack.config.js

@@ -1,8 +1,8 @@
+const path = require('path');
 const { merge } = require('webpack-merge');
 const {
   TerraDevSite,
 } = require('@cerner/terra-dev-site');
-const path = require('path');
 
 const WebpackConfigTerra = require('@cerner/webpack-config-terra');