refactor: more generic target handling #440
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
cert-manager-prow
bot
added
the
dco-signoff: no
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
size/M
erikgb
force-pushed
the
generic-target
branch
from
d12035b
to
8dc88a7
Compare
cert-manager-prow
bot
added
dco-signoff: yes
erikgb
changed the title
cert-manager-prow
bot
removed
the
do-not-merge/work-in-progress
erikgb
force-pushed
the
generic-target
branch
from
8dc88a7
to
58b3087
Compare
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
erikgb
force-pushed
the
generic-target
branch
from
ee92b5d
to
0f872e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I am trying to make the code for handling targets (configmaps and secrets) even more generic. My initial goal was to fully remove the code duplication for configmaps/secrets, but I do see (at least not now) how that can be done. I am suggesting merging this as a step forward for now.