Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing boundary checks on masked grids #114
Fixing boundary checks on masked grids #114
Changes from 7 commits
4a92d6e
ca57619
77fd5e1
aa7ef4e
dd042d8
f6c5719
aa7f88c
b8be33f
5dd7c2c
a6876ba
8595100
be564b8
5144f92
8bcfefb
f7538d6
9ae4999
84508de
211ccb4
bd5098d
0e921bf
6850dc2
d7eff3b
1af845a
607885d
00421ae
330ff3f
e112673
c0d7394
25fd24e
1f50575
d9e034b
2001258
e268d79
f5e4777
0aeefc0
2777e96
ad744de
ce4d5bc
68f045b
03ff760
421f465
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
inbounds(data, i)
does exactly this for youThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True! And it's better cause I don't need to specify the boundary condition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we try to keep anything related to boundary conditions, aux data, masks etc out of rules and in the
data
object. Then we can swap them around without changing all our code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.