Add pentagrow for automatic hybrid mesh generation #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
==========================================
- Coverage 69.47% 62.39% -7.08%
==========================================
Files 84 89 +5
Lines 8148 8989 +841
==========================================
- Hits 5661 5609 -52
- Misses 2487 3380 +893
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
saved the pentagrow command to file and then executed
GBenedett
commented
Feb 22, 2024
ceasiompy/CPACS2GMSH/README.md
Outdated
| `CPACS2GMSH` is an automatic mesh generator module for a [CPACS](https://www.cpacs.de) aircraft geometry [[1]](#Alder20) using [GMSH](https://gmsh.info/) ,a finite element mesh generator. An unstructured mesh is automatically generated in a spherical domain surrounding the aircraft. The resulting mesh can be used for a CFD calculation by connecting the `SU2Run` module after `CPACS2GMSH` module. | ||
| `CPACS2GMSH` is an automatic mesh generator module for a [CPACS](https://www.cpacs.de) aircraft geometry [[1]](#Alder20) using [GMSH](https://gmsh.info/) ,a finite element mesh generator. An unstructured mesh is automatically generated in a spherical domain surrounding the aircraft. | ||
|
|
||
| <!-- if RANS is "True" the mesh 2d is generated by [GMSH] and by using [TETGEN] (https://wias-berlin.de/software/tetgen/1.5/doc/manual/manual.pdf) an hybrid spherical domain is automatically generated, thank to the command "Pentagrow". --> |
There was a problem hiding this comment.
wrong position in the read me, and bad formatted
GBenedett
commented
Feb 22, 2024
| @@ -95,6 +127,8 @@ Engine exhaust surface position from the back of the engine fan cowl in percent | |||
|
|
|||
| At the time of writing, this module is not able to handle aircraft with control surfaces (they will not be modelled and thus appear in the final mesh). | |||
|
|
|||
| <!-- For the RANS part, it is only possible to process aircraft consisting of .brep files of category 'fuselage' and 'wing' --> | |||
|
|
|||
There was a problem hiding this comment.
You should add somewhere the part of pentagrow, and clarify the 2 workflow
…SIOMpy into add_pentagrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from the 2D mesh generated by gmsh, the goal is to obtain a 3D mesh with boundary layer for RANS simulation.