ThermoData branch #294
Merged
ThermoData branch #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GBenedett
added
SU2
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
==========================================
- Coverage 63.76% 63.22% -0.55%
==========================================
Files 84 88 +4
Lines 8150 8804 +654
==========================================
+ Hits 5197 5566 +369
- Misses 2953 3238 +285
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GBenedett
commented
Feb 21, 2024
ceasiompy/ThermoData/README.md
Outdated
|
|
||
| <br /> | ||
|
|
||
| `ThermoData` is a module to provide the outlet conditions of a given engine. It can calculate different operating conditions and save the results in a text file. This module is derived starting from the OpenSource code [pyCycle](https://github.com/OpenMDAO/pycycle) developed by Eric S. Hendricks and Justin S. Gray. It can perform calculations on both turbojet and turbofan engines, with the possibility to customize the parameters. The results are automatically written inside the config file of the module `SU2Run` to be able to perform the calculations. |
There was a problem hiding this comment.
which parameters?
configuration file
GBenedett
commented
Feb 21, 2024
ceasiompy/ThermoData/README.md
Outdated
| `ThermoData` is a module to provide the outlet conditions of a given engine. It can calculate different operating conditions and save the results in a text file. This module is derived starting from the OpenSource code [pyCycle](https://github.com/OpenMDAO/pycycle) developed by Eric S. Hendricks and Justin S. Gray. It can perform calculations on both turbojet and turbofan engines, with the possibility to customize the parameters. The results are automatically written inside the config file of the module `SU2Run` to be able to perform the calculations. | ||
|
|
||
| ## Inputs | ||
| `ThermoData` can be run on is own by giving the altitude the Mach number and the Net force. Otherwise it can take as an input the values from `CPACS2GMSH` module. |
There was a problem hiding this comment.
altitude and Mach are inside aeromap, maybe change the sentence
GBenedett
commented
Feb 21, 2024
ceasiompy/ThermoData/README.md
Outdated
| `ThermoData` compute the values obtained at the engine outlet giving a "EngineBC.dat" file as an output. if the workflow continues with the `SU2Run` run module the results are added to the config file to perform the simulation. | ||
|
|
||
| ## Outputs | ||
| `ThermoData` output is the "EngineBC.dat" file with stored inside: T_tot_out, V_stat_out, MN_out, P_tot_out, massflow_stat_out, T_stat_out, P_stat_out for the chosen engine configuration. |
There was a problem hiding this comment.
add complete names, i.e. T_tot_out= Nozzle outlet temperature
…ASIOMpy into add_ThermoData
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add-on module to include engine boundary conditions for thermodynamic calculations