Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read/write attribute directly from @attributes to match ActiveModel #122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Read/write attribute directly from @attributes to match ActiveModel #122

wants to merge 2 commits into from

Commits on Jul 6, 2013

  1. Read/write attribute directly from @attributes to match ActiveModel 

    This allows overridden getters/setters to be written like ActiveModel
getters/setters and call `read_attribute` and `write_attribute` to get
the raw value from the attributes hash. This previous behavior was
unexpected to users bring existing code from ActiveModel.

The other benefit of this change is that `ActiveModel::Dirty` can be
included and will actually behave properly since it overrides
`write_attribute`, expecting it to be called when a setter is called.

Signed-off-by: Evan Owen <kainosnoema@gmail.com>
    @kainosnoema
    kainosnoema committed Jul 6, 2013
    Configuration menu
    Copy the full SHA
    f1fbcf9 View commit details
    Browse the repository at this point in the history

  2. Use un-overriden (but typecast) values when returning attributes hash 

    This more closely matches the behavior of ActiveRecord, further
reducing unexpected behavior for users familiar with AR.

Signed-off-by: Evan Owen <kainosnoema@gmail.com>
    @kainosnoema
    kainosnoema committed Jul 6, 2013
    Configuration menu
    Copy the full SHA
    698fb51 View commit details
    Browse the repository at this point in the history