Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[person/department] new func to add department or get one by name #330

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

flablog
Copy link
Contributor

@flablog flablog commented Aug 1, 2024

Problem
There was no way to create a department from Gazu, neither looking for one by name

Solution
Added 2 functions to enable developers to create departments from Gazu and to search a department by name

@flablog
Copy link
Contributor Author

flablog commented Aug 1, 2024

This is a PR that we can consider a test as for the questions I'm raising in #329
For eample, there is no tests here, as I'm not sure how to make it.
And I put the functions where there is the only related department function, but maybe it needs its own file ? Like departments.py ?

@EvanBldy
Copy link
Member

EvanBldy commented Aug 7, 2024

Hi @flablog,
It's a good idea to let the functions in person's file.
I have added the tests for your functions and added a function gazu.person.get_department.

Thanks a lot for your work, have a nice day :)

@EvanBldy EvanBldy merged commit 02f618d into cgwire:master Aug 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants