Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Add FLIC dataset #495

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add FLIC dataset #495

wants to merge 11 commits into from

Conversation

mitmul
Copy link
Member

@mitmul mitmul commented Dec 11, 2017

This PR adds a dataset class for human pose dataset FLIC. It follows the convention of keypoint dataset like CUBKeypointDataset.


]

flic_joint_label_names = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about flic_joint_names?

the FLIC dataset.
return_torsobox (bool): If :obj:`True`, this returns a bounding box
around the torso. The default value is :obj:`False`.
skip_bad (bool): If :obj:`True`, the data which have :obj:`isbad = 1`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about use_bad and use_unchecked?
This style is consistent with the other datasets.
https://github.com/chainer/chainercv/blob/master/chainercv/datasets/voc/voc_bbox_dataset.py#L70

'isbad',
'isunchecked',
]
labels = loadmat(os.path.join(data_dir, 'FLIC-full', 'examples.mat'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about annos?
labels is overused in ChainerCV already.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, label_key -> anno_key.

Args:
data_dir (string): Path to the root of the training data. If this is
:obj:`auto`, this class will automatically download data for you
under :obj:`$CHAINER_DATASET_ROOT/pfnet/chainercv/cub`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cub -> flic

urls = [
'http://vision.grasp.upenn.edu/video/FLIC-full.zip',

'http://cims.nyu.edu/~tompson/data/tr_plus_indices.mat',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you delete this, or comment what this is?

data_root,
ext)

return data_root
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this function return
$CHAINER_ROOT/pfnet/chainercv/flic/FLIC-full ?
This is more consistent with other download functions.

@yuyu2172
Copy link
Member

yuyu2172 commented Dec 18, 2017

Nice PR.
Please delete lsp files.
Also, add a link to the documentation.

@yuyu2172 yuyu2172 self-assigned this Dec 18, 2017
@yuyu2172 yuyu2172 mentioned this pull request Dec 23, 2017
@mitmul
Copy link
Member Author

mitmul commented Dec 27, 2017

@yuyu2172 Thanks for the review. I've fixed the points.

@knorth55 knorth55 added this to the 0.12 milestone Nov 1, 2018
@knorth55 knorth55 modified the milestones: 0.12, 0.13 Feb 2, 2019
@mitmul
Copy link
Member Author

mitmul commented Apr 14, 2019

Not sure what's blocking this PR, but just resolved conflicts for now.

@yuyu2172
Copy link
Member

yuyu2172 commented May 21, 2019

Please wait until #787 is merged

@yuyu2172 yuyu2172 modified the milestones: 0.13, 1.0 May 21, 2019
@knorth55 knorth55 removed this from the 1.0 milestone Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants