Skip to content

Commit

Permalink
Make aws-redis-node match internal lib, upgrade default (#146)
Browse files Browse the repository at this point in the history
Make aws-redis-node match internal lib, upgrade defaultPorting arguments and defaults from CZI internal module library (with the intent of deleting the internal lib module in favor of this one), and upgrading default Redis engine from 5.0.3 to 5.0.5
  • Loading branch information
mbarrien authored and czimergebot committed Oct 10, 2019
1 parent 5f1e8fe commit 3f3b0f5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion aws-redis-node/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ resource "aws_elasticache_subnet_group" "default" {
resource "aws_elasticache_cluster" "default" {
cluster_id = "${var.resource_name != "" ? var.resource_name : local.name}"
engine = "redis"
engine_version = "3.2.6"
engine_version = "${var.engine_version}"
node_type = "${var.instance_type}"
port = "${var.port}"
num_cache_nodes = 1
Expand Down
7 changes: 4 additions & 3 deletions aws-redis-node/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ variable "subnets" {
variable "availability_zone" {
type = "string"
description = "Availability zone in which this instance should run."
default = null
}

variable "ingress_security_group_ids" {
Expand All @@ -42,17 +43,17 @@ variable "port" {
variable "instance_type" {
type = "string"
description = "The type of instance to run. See [supported node types](https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/CacheNodes.SupportedTypes.html)"
default = "cache.m4.large"
default = "cache.m5.large"
}

variable "parameter_group_name" {
default = "default.redis3.2"
default = "default.redis5.0"
}

variable "engine_version" {
type = "string"
description = "The version of Redis to run. See [supported versions](https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/supported-engine-versions.html)"
default = "4.0.10"
default = "5.0.5"
}

variable "apply_immediately" {
Expand Down

0 comments on commit 3f3b0f5

Please sign in to comment.