Skip to content

Commit

Permalink
Remove install button on napari-hub (#1016)
Browse files Browse the repository at this point in the history
* initial commit to remove the necessary install components

* revert fixture edit, which was meant for testing purposes

* revert fixture edit, which was meant for testing purposes

* revert fixture edit, which was meant for testing purposes

* revert fixture edit, which was meant for testing purposes

* revert fixture edit, which was meant for testing purposes

* code to remove files and references to those files/components

* got rid of installation button in test

* deleted unused components
  • Loading branch information
klai95 authored May 3, 2023
1 parent f5e696f commit 0303ed2
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 297 deletions.
8 changes: 0 additions & 8 deletions frontend/e2e/tests/plugin/details.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,10 @@ import {
ACTIVITY,
AUTHOR,
BODY_ACTIVITY_PAGE,
BUTTON,
CLEAR_SEARCH,
CONTRIBUTING,
CONTRIBUTING_HEADER,
HEADER_REGION,
INSTALL,
ISSUES,
ISSUES_HEADER,
LICENSE,
Expand All @@ -35,7 +33,6 @@ import {
SEARCH_BUTTON,
SEARCH_INPUT,
SEARCH_RESULT,
SIDE_BAR,
SUPPORTED_DATA,
USAGE,
} from '../../utils/constants';
Expand Down Expand Up @@ -75,11 +72,6 @@ test.describe('Plugin details tests', () => {
// verify author
expect(await page.locator(AUTHOR).textContent()).toBe(data.authors[0].name);

// installation button
expect(await page.locator(SIDE_BAR).getByTestId(BUTTON).textContent()).toBe(
INSTALL,
);

// verify the url
expect(page.url()).toContain(data.name);

Expand Down
63 changes: 0 additions & 63 deletions frontend/src/components/PluginPage/CallToActionButton.tsx

This file was deleted.

216 changes: 0 additions & 216 deletions frontend/src/components/PluginPage/InstallModal.tsx

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import clsx from 'clsx';

import { CallToActionButton } from '@/components/PluginPage/CallToActionButton';
import { SupportInfo } from '@/components/PluginPage/SupportInfo';
import { SkeletonLoader } from '@/components/SkeletonLoader';

Expand All @@ -14,7 +13,6 @@ export function PluginActions() {
'mt-sds-xl',
)}
>
<CallToActionButton />
<SkeletonLoader className="h-[228px]" render={() => <SupportInfo />} />
</div>
);
Expand Down
2 changes: 0 additions & 2 deletions frontend/src/components/PluginPage/PluginPageContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { SkeletonLoader } from '@/components/SkeletonLoader';
import { usePluginState } from '@/context/plugin';
import { useMediaQuery } from '@/hooks';

import { CallToActionButton } from './CallToActionButton';
import { CitationInfo } from './CitationInfo';
import { PluginMetadata } from './PluginMetadata';

Expand Down Expand Up @@ -38,7 +37,6 @@ export function PluginPageContent() {
/>

<div className="mb-6 screen-495:mb-12 screen-1150:mb-20">
<CallToActionButton />
{plugin?.citations && <CitationInfo className="mt-sds-xxl" />}
</div>

Expand Down
3 changes: 0 additions & 3 deletions frontend/src/components/PluginPage/PluginRightColumn.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { useIsFeatureFlagEnabled } from '@/store/featureFlags';
import { pluginTabsStore } from '@/store/pluginTabs';
import { PluginTabType } from '@/types/plugin';

import { CallToActionButton } from './CallToActionButton';
import { ANCHOR } from './CitationInfo.constants';
import { SupportInfo } from './SupportInfo';

Expand Down Expand Up @@ -75,8 +74,6 @@ export function PluginRightColumn() {
<div className="col-start-4 screen-1425:col-start-5 hidden screen-1150:block">
{/* Keep CTA button and TOC on screen when scrolling on 2xl. */}
<div className="sticky top-[50px]">
<CallToActionButton />

<SkeletonLoader
className="h-[228px] my-6"
render={() => (
Expand Down
3 changes: 0 additions & 3 deletions frontend/src/components/PluginPage/PluginTabs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import { pluginTabsStore, resetPluginTabs } from '@/store/pluginTabs';
import { HubDimension } from '@/types';
import { PluginTabType } from '@/types/plugin';

import { CallToActionButton } from './CallToActionButton';
import { CitationInfo } from './CitationInfo';
import { PluginMetadata } from './PluginMetadata';

Expand Down Expand Up @@ -135,8 +134,6 @@ export function PluginTabs({ containerRef }: Props) {
)}
/>

<CallToActionButton className="mb-6 screen-495:mb-12 screen-1150:mb-20" />

<PluginMetadata
enableScrollID={hasPluginMetadataScroll}
className="screen-1425:hidden"
Expand Down

0 comments on commit 0303ed2

Please sign in to comment.