Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wmg): implement gene length normalization #6013

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

atarashansky
Copy link
Contributor

Reason for Change

  • #TICKET_NUMBER
  • If the reason for this PR's code changes are not clear in the issue, state value/impact

Changes

  • add
  • remove
  • modify

Testing steps

  • Either list QA steps or reasoning you feel QA is unnecessary
  • Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
  • "Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Notes for Reviewer

@atarashansky atarashansky changed the base branch from main to atar-wmg-base October 17, 2023 16:14
Copy link
Contributor

@kaloster kaloster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for readability!

@sidneymbell sidneymbell requested review from sidneymbell and removed request for sidneymbell October 17, 2023 20:19
@atarashansky atarashansky requested review from pablo-gar and removed request for sidneymbell October 17, 2023 22:12
@atarashansky atarashansky merged commit fa750c1 into atar-wmg-base Oct 18, 2023
20 of 29 checks passed
@atarashansky atarashansky deleted the atar-wmg-gene-length-norm branch October 18, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants