Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wmg): improve default wmg cube schema #6058

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

atarashansky
Copy link
Contributor

@atarashansky atarashansky commented Oct 22, 2023

Reason for Change

  • Using hilbert ordering for the expression summary default cube was bad for performance once after the WMGv2 changes to the backend. This reverts the schema to be row-ordered like the full expression summary cube.

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #6058 (6799ce9) into main (76a4449) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6058   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files         169      169           
  Lines       13883    13883           
=======================================
  Hits        12541    12541           
  Misses       1342     1342           
Flag Coverage Δ
unittests 90.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
backend/wmg/data/schemas/cube_schema_default.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Deployment Summary

@atarashansky atarashansky merged commit 7dd965e into main Oct 23, 2023
41 checks passed
@atarashansky atarashansky deleted the atar-fix-schema branch October 23, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants