Add linter rule for missing in intents #26115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
chplcheck
rule to inform users that formals that initialize a field should have an in intent. Doing this can reduce the number of copies made and improve performance.This PR takes the following approach to implement this
init this
, warnNote that this only handles the cases where the left hand side of
=
can be scope resolved, so something likethis.field = myFormal
will not trigger the warning yetFuture work: As the resolver comes online and is threaded into
chplcheck
, this lint rule should make use of the logic inInitResolver
to distinguish between initialization and assignment.[Reviewed by @DanilaFe]