Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dyno resolve returns within param for loop #26158

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

riftEmber
Copy link
Member

@riftEmber riftEmber commented Oct 29, 2024

Add dyno support for returns from within param for loops, matching production behavior.

Implemented by extending ReturnTypeInferrer to descend into param for loops, and respect break and continue statements which it can now encounter.

Includes adding testing for the fixed case, as well as several similar patterns of returning within a param loop.

Resolves https://github.com/Cray/chapel-private/issues/6787.

[reviewer info placeholder]

Testing:

  • dyno tests
  • paratest
  • resolves reproducer from backing issue

@riftEmber riftEmber changed the title Initial fix for return in param for Fix resolving type of returns within param for loop Oct 29, 2024
@riftEmber riftEmber changed the title Fix resolving type of returns within param for loop Dyno resolve returns within param for loop Oct 29, 2024
@riftEmber riftEmber force-pushed the dyno-param-for-return branch 6 times, most recently from 510a657 to e59adff Compare October 29, 2024 20:45
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
@riftEmber riftEmber marked this pull request as ready for review October 29, 2024 21:30
@DanilaFe
Copy link
Contributor

I can review when you feel the PR needs that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants