Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --gpus-per-node as a CLI argument and in slurm-gasnetrun* launchers #26166

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jabraham17
Copy link
Member

Expands the work done in #24608 to support --gpus-per-node both as a CLI argument to the slurm-srun launcher and to add it as an option for slurm-gasnetrun* launchers.

Prior to this PR, users could only specify CHPL_LAUNCHER_GPUS_PER_NODE as an environment variable, and this variable was not respected by all slurm based launchers.

Note: This PR adds the CLI argument as this is a key slurm argument that some systems need. This also makes gpus feel more like a first-class Chapel feature for slurm based launchers.

Testing:

  • test both env var and CLI flag with CHPL_LAUNCHER=slurm-srun
  • test both env var and CLI flag with CHPL_LAUNCHER=slurm-gasnetrun_ibv

[Reviewed by @]

Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants