-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(presence): implemented presence function #2123
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing,It's looking good so far!. The PR must usually come with 5 files modified. You can see an example in this PR. This PR is missing typings and typings tests. Also please have a look at my code review comments.
@char0n i'll take a look to the requests, thank u by the way. |
Codecov Report
@@ Coverage Diff @@
## master #2123 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 234 234
Lines 622 622
=======================================
Hits 612 612
Misses 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I'm not sure I understand changes that have been made to this PR during last 3 commits. Now we should also fully utilize const presence = when(isBlank, stubNull); Notes to above implementation:
|
@char0n i got it .. i'll update it later .. |
Right, let me know if you need any assistence |
Implemented
presence
function.Issue: #654