Correct handling of SerialKind.CONTEXTUAL in YamlInput class
#582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OptimumCode
changed the title
SerialKind.CONTEXTUAL in YamlInput class
charleskorn
reviewed
Jun 30, 2024
There was a problem hiding this comment.
Thanks for fixing this @OptimumCode!
I have one comment about the test, but otherwise this looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @charleskorn.
This PR corrects how
YamlInputhandles the serialization of fields marked with@Contextualannotation.Instead of forcing the serializer to call
beginStructureit extracts the actual definition and creates the appropriateYamlInputbased on that definition where applicable.Please, take a look at the PR once you have time. Let me know if you have any remarks/suggestions regarding the change
Resolves #568