Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kotlinx.IO #591

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use Kotlinx.IO #591

wants to merge 2 commits into from

Conversation

mani1232
Copy link

No description provided.

@mani1232 mani1232 changed the title Use IO Use Kotlinx.IO Jul 17, 2024
@charleskorn
Copy link
Owner

Could you please provide some more context on why you think this change should be made?

@mani1232
Copy link
Author

Could you please provide some more context on why you think this change should be made?

It's not a very serious reason. But it can be done, as I don't see the need for Okio and its dependencies anymore.

@JakeWharton
Copy link

Okio has no dependencies.

@mani1232
Copy link
Author

Okio has no dependencies.

ok, but

kotlinx.io use 2.x.x kotlin version
The size of kotlinx.io is x2-2.5 times smaller

So far, other than alpha status, I don't see any downsides.

@JakeWharton
Copy link

The version of Kotlin is irrelevant—it's a compiled dependency. The version a dependency uses does not affect its consumers other than setting a stdlib version floor.

Size also shouldn't matter. On every platform you only pay for what you use. The design of kotlinx.io is exactly the same as Okio so in the final binary each will cost the same.

The only consideration here is the fact that one API is ABI stable and the other is not. Should you use kotlinx.io over Okio once it's ABI stable? Always. Should you today when you will have to chase compatibility with every release? That's the only important question here.

@mani1232
Copy link
Author

mani1232 commented Aug 1, 2024

The version of Kotlin is irrelevant—it's a compiled dependency. The version a dependency uses does not affect its consumers other than setting a stdlib version floor.

Size also shouldn't matter. On every platform you only pay for what you use. The design of kotlinx.io is exactly the same as Okio so in the final binary each will cost the same.

The only consideration here is the fact that one API is ABI stable and the other is not. Should you use kotlinx.io over Okio once it's ABI stable? Always. Should you today when you will have to chase compatibility with every release? That's the only important question here.

about size - compared only jvm target

About the api status, yes, I agree.

@charleskorn
Copy link
Owner

Sorry, until kotlinx.io's interface is stable, I'm not prepared to accept this change.

Copy link

stale bot commented Oct 5, 2024

This issue has been automatically marked as stale because it has not had any activity in the last 60 days. It will automatically be closed if no further activity occurs in the next seven days to enable maintainers to focus on the most important issues.
If this issue is still affecting you, please comment below within the next seven days.
Thank you for your contributions.

@stale stale bot added the stale label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants