feat(term): termios package #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help us remove the dep on u-root/u-root from /ssh, and also adds support to netbsd. This one is less generic though, and specifically made to be used with ssh.TerminalModes, which is our main use case for now. Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
caarlos0
added a commit
to charmbracelet/ssh
that referenced
this pull request
Feb 1, 2024
refs charmbracelet/x#35 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
aymanbagabas
reviewed
Feb 1, 2024
|
Assuming dragonfly uses the same syscalls, its possible yeah. agreed, wouldn't hurt to |
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
only on linux, on other OSs this will help by simply failing to compile Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
|
to limit the scope a bit: we usually release for these OS: goos:
- linux
- darwin
- windows
- freebsd
- openbsd
- netbsd
goarch:
- amd64
- arm64
- "386"
- arm
goarm:
- "7"
ignore:
- goos: windows
goarch: arm64
- goos: windows
goarm: "7"so I gonna make it work for them primarly ⭐️ |
aymanbagabas
reviewed
Feb 1, 2024
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
caarlos0
added a commit
to charmbracelet/ssh
that referenced
this pull request
Feb 2, 2024
* refactor: use new termios lib refs charmbracelet/x#35 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: darwin Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * chore: update * chore: update dep --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help us remove the dep on u-root/u-root from /ssh, and also adds support to netbsd.
The api is different, and it does not use reflection.