refactor(term): move conpty out of windows #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match golang/sys, the windows package should contain Windows specific API calls. The conpty package is a high-level package that creates and manages ConPty sessions, and thus wouldn't make sense to keep it under windows.
caarlos0
reviewed
Feb 26, 2024
caarlos0
approved these changes
Feb 27, 2024
dezren39
added a commit
to developing-today-forks/ssh
that referenced
this pull request
Mar 1, 2024
aymanbagabas
pushed a commit
to charmbracelet/ssh
that referenced
this pull request
Mar 1, 2024
* update x conpty module moved out of windows charmbracelet/x#43 * fix comment
dezren39
added a commit
to developing-today-forks/promwish
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match golang/sys, the windows package should contain Windows specific API calls. The conpty package is a high-level package that creates and manages ConPty sessions, and thus wouldn't make sense to keep it under windows.