Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove box padding from legend types #11817

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Remove box padding from legend types #11817

merged 1 commit into from
Jun 26, 2024

Conversation

LeeLenaleee
Copy link
Collaborator

Resolves: #11803, boxPadding does not exist on the legend plugin, it only exists on the tooltip plugin

@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Jun 24, 2024
@LeeLenaleee LeeLenaleee added this to the 4.5.0 milestone Jun 24, 2024
etimberg
etimberg previously approved these changes Jun 24, 2024
View reviewed changes
@LeeLenaleee LeeLenaleee force-pushed the remove-boxpadding-from-types branch from 0889cbf to 43e8bf4 Compare June 24, 2024 19:17
@LeeLenaleee
Copy link
Collaborator Author

Fixed the CI, forgot to disable autoformat of VS code

@LeeLenaleee LeeLenaleee requested a review from etimberg June 26, 2024 08:18
@LeeLenaleee LeeLenaleee merged commit 19c02c8 into chartjs:master Jun 26, 2024
8 checks passed
@LeeLenaleee LeeLenaleee deleted the remove-boxpadding-from-types branch June 26, 2024 12:01
@Tomut0 Tomut0 mentioned this pull request Sep 11, 2024
Merged
@jbrown-xentity jbrown-xentity mentioned this pull request Sep 11, 2024
Merged
@bsimmons123 bsimmons123 mentioned this pull request Sep 11, 2024
Open
@rahatutzaman-rizon rahatutzaman-rizon mentioned this pull request Sep 11, 2024
Open
@MiguelPelegrina MiguelPelegrina mentioned this pull request Sep 11, 2024
Merged
@mohamed-helmy22020 mohamed-helmy22020 mentioned this pull request Sep 11, 2024
Open
@diaz-rigo diaz-rigo mentioned this pull request Sep 11, 2024
Open
@respencer respencer mentioned this pull request Sep 11, 2024
Closed
@domin-mnd domin-mnd mentioned this pull request Sep 11, 2024
Open
@respencer respencer mentioned this pull request Sep 12, 2024
Closed
@X-oss-byte X-oss-byte mentioned this pull request Sep 12, 2024
Open
@saeedhmohd244 saeedhmohd244 mentioned this pull request Sep 12, 2024
Open
@bagulm123 bagulm123 mentioned this pull request Sep 13, 2024
Open
@opicciotto opicciotto mentioned this pull request Sep 14, 2024
Closed
@mytamDo mytamDo mentioned this pull request Sep 16, 2024
Open
@karencapiiro karencapiiro mentioned this pull request Sep 17, 2024
Open
@bagulm123 bagulm123 mentioned this pull request Sep 18, 2024
Open
@respencer respencer mentioned this pull request Sep 18, 2024
Closed
@vigneshshettyin vigneshshettyin mentioned this pull request Sep 18, 2024
Closed
@respencer respencer mentioned this pull request Sep 20, 2024
Closed
@jcampb98 jcampb98 mentioned this pull request Sep 20, 2024
Merged
@vigneshshettyin vigneshshettyin mentioned this pull request Sep 21, 2024
Closed
@dariosalvi78 dariosalvi78 mentioned this pull request Sep 22, 2024
Open
@vigneshshettyin vigneshshettyin mentioned this pull request Sep 22, 2024
Closed
@scottwad scottwad mentioned this pull request Sep 24, 2024
Open
@mytamDo mytamDo mentioned this pull request Sep 24, 2024
Open
@respencer respencer mentioned this pull request Sep 24, 2024
Closed
@raymondhtet raymondhtet mentioned this pull request Sep 25, 2024
Open
@FuhuXia FuhuXia mentioned this pull request Sep 26, 2024
Merged
@bagulm123 bagulm123 mentioned this pull request Oct 1, 2024
Open
@vigneshshettyin vigneshshettyin mentioned this pull request Oct 5, 2024
Closed
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 27, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 27, 2024
Open
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 28, 2024
Open
@digiserg digiserg mentioned this pull request Nov 6, 2024
Merged
@FelipeX30 FelipeX30 mentioned this pull request Nov 6, 2024
Open
@tungnxt89 tungnxt89 mentioned this pull request Nov 9, 2024
Closed
@FuhuXia FuhuXia mentioned this pull request Nov 9, 2024
Merged
@Eskedar21 Eskedar21 mentioned this pull request Nov 9, 2024
Open
@Niaz-estefaie Niaz-estefaie mentioned this pull request Nov 12, 2024
Open
@paul-nhlapo paul-nhlapo mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 4.4.4
Development

Successfully merging this pull request may close these issues.

Legend: boxPadding does nothing
2 participants
@LeeLenaleee @etimberg