chore: CRW-4820 bump to node 18...

[nickboldt]

What does this PR do?

chore: CRW-4820 bump to node 18 requirement

Change-Id: If63b174ae61f8fef473c35d5ada426bc963b6359
Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works, if one exists
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nickboldt]

/retest-required

[tolusha]

Depends on #2731 #2733 #2734

[tolusha]

/retest

[tolusha]

/retest

[SDawley]

If everyone seems to be convinced that these are just unrelated test failures, can we merge?

[tolusha]

Unfortunately we can't merge since won't be able to run tests against OpenShift CI.
The idea is to have Node 18 here [1]

[1] https://github.com/che-incubator/chectl/blob/main/.ci/openshift-ci/Dockerfile

[codecov-commenter]

Codecov Report

Merging #2731 (ec8ec30) into main (ba3aa89) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #2731   +/-   ##
=======================================
  Coverage   10.36%   10.36%           
=======================================
  Files          52       52           
  Lines        4283     4283           
  Branches      645      645           
=======================================
  Hits          444      444           
  Misses       3839     3839           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[nickboldt]

Using new dockerfile I was able to build w/ node 18:

FROM registry.access.redhat.com/ubi9/nodejs-18:1
USER 0
RUN dnf install -y -q --allowerasing --nobest nodejs-devel nodejs-libs \
  # already installed or installed as deps:
  openssl openssl-devel ca-certificates make cmake cpp gcc gcc-c++ zlib zlib-devel brotli brotli-devel python3 nodejs-packaging && \
  dnf update -y && dnf clean all && \
  npm install -g yarn@1.22 npm@9 && \
  echo -n "node version: "; node -v; \
  echo -n "npm  version: "; npm -v; \
  echo -n "yarn version: "; yarn -v

COPY . /opt/app-root/src
RUN yarn && yarn pack && yarn test

podman build -f .ci/openshift-ci/Dockerfile -t openshift-ci .
podman run -it --rm --entrypoint /bin/bash --user root openshift-ci

then in the container:

bash-5.1# ls -la /opt/app-root/src/*gz
-rw-r--r-- 1 root root 136908 Aug 30 16:28 /opt/app-root/src/chectl-v0.0.2.tgz

bash-5.1# cd /opt/app-root/src/; ./bin/run --version
chectl/0.0.2 linux-x64 node-v18.16.1

bash-5.1# cd /opt/app-root/src/; ./bin/run server:update --help
Update Eclipse Che server.

USAGE
  $ chectl server:update
...

[openshift-ci]

@nickboldt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v12-chectl	ec8ec30	link	true	/test v12-chectl
ci/prow/v11-chectl	ec8ec30	link	true	/test v11-chectl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[devstudio-release]

Build 3.9 :: dsc_3.x/1295: Console, Changes, Git Data

[devstudio-release]

Build 3.9 :: dsc_3.x/1296: Console, Changes, Git Data

[devstudio-release]

Build 3.9 :: dsc_3.x/1296:

3.9.0 CI

[devstudio-release]

Build 3.9 :: dsc_3.x/1297: Console, Changes, Git Data

[devstudio-release]

Build 3.9 :: dsc_3.x/1297:

3.9.0 CI

[devstudio-release]

Build 3.9 :: dsc_3.x/1298: Console, Changes, Git Data

[devstudio-release]

Build 3.9 :: dsc_3.x/1298:

3.9.0 CI