-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: CRW-4820 bump to node 18... #2731
Conversation
Change-Id: If63b174ae61f8fef473c35d5ada426bc963b6359 Signed-off-by: Nick Boldt <nboldt@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nickboldt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change-Id: Iaf15b8f16a799e7f5a2cba199fd7bff51ec61b58 Signed-off-by: Nick Boldt <nboldt@redhat.com>
Change-Id: I004cb297833156ae182fd7bbb11377e97da50eb6 Signed-off-by: Nick Boldt <nboldt@redhat.com>
/retest-required |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
/retest |
/retest |
If everyone seems to be convinced that these are just unrelated test failures, can we merge? |
Unfortunately we can't merge since won't be able to run tests against OpenShift CI. [1] https://github.com/che-incubator/chectl/blob/main/.ci/openshift-ci/Dockerfile |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Change-Id: I278dff1d88bfb51767d53a3e62f995b568dc1af1 Signed-off-by: Nick Boldt <nboldt@redhat.com>
Change-Id: I4acfc99eae0a0e45804f4c2c54bfd73a4c4931e6 Signed-off-by: Nick Boldt <nboldt@redhat.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2731 +/- ##
=======================================
Coverage 10.36% 10.36%
=======================================
Files 52 52
Lines 4283 4283
Branches 645 645
=======================================
Hits 444 444
Misses 3839 3839 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Using new dockerfile I was able to build w/ node 18:
then in the container:
|
@nickboldt: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Build 3.9 :: dsc_3.x/1295: Console, Changes, Git Data |
Build 3.9 :: dsc_3.x/1296: Console, Changes, Git Data |
Build 3.9 :: dsc_3.x/1296: 3.9.0 CI |
Build 3.9 :: dsc_3.x/1297: Console, Changes, Git Data |
Build 3.9 :: dsc_3.x/1297: 3.9.0 CI |
Build 3.9 :: dsc_3.x/1298: Console, Changes, Git Data |
Build 3.9 :: dsc_3.x/1298: 3.9.0 CI |
What does this PR do?
chore: CRW-4820 bump to node 18 requirement
Change-Id: If63b174ae61f8fef473c35d5ada426bc963b6359
Signed-off-by: Nick Boldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A (or see commit message above for issue number)
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.