fix: Remove the process to check OIDC provider on server:deploy

[ynqa]

What does this PR do?

• Remove --skip-oidc-provider-check flag and its logic.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#23047

How to test this PR?

%./bin/run server:deploy --skip-oidc-provider-check
Error: Nonexistent flag: --skip-oidc-provider-check

PR Checklist

As the author of this Pull Request I made sure that:

• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[openshift-ci]

Hi @ynqa. Thanks for your PR.

I'm waiting for a che-incubator member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tolusha]

@ynqa
Thank you for contribution.
Could you sign your commits please to be able to merge the PR

https://github.com/che-incubator/chectl/pull/2902/checks?check_run_id=27833382813

[ynqa]

Could you sign your commits please to be able to merge the PR

@tolusha Signed.

[tolusha]

Hello, @ynqa
I remembered why I completed removed invocation getEnsureOIDCProviderInstalledTask from the codebase.
It causes more issues than benefits, since it is really hard to check if OIDC is configured in all kinds of clusters.
And usually I recommended to add --skip-oidc-provider-check flag.

[ynqa]

It causes more issues than benefits, since it is really hard to check if OIDC is configured in all kinds of clusters.

@tolusha Yes, on EKS kube-apiserver is not exposed for users. The alternative of this pull request is to remove this flag and logic altogether for avoidance of confusion.

[tolusha]

The alternative of this pull request is to remove this flag and logic altogether for avoidance of confusion.

+1

[ynqa]

@tolusha Sure. I will remove them.

[ynqa]

@tolusha Removed at d117f79

[tolusha]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha, ynqa

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[devstudio-release]

Build 3.16 :: dsc_3.x/1963: Console, Changes, Git Data

[devstudio-release]

Build 3.16 :: dsc_3.x/1963:

3.16.0-CI