-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for versions of ruby prior to 2.6 #381
base: main
Are you sure you want to change the base?
Conversation
7fdf4b4
to
14709ff
Compare
14709ff
to
c69e8ca
Compare
c69e8ca
to
b5d0ac2
Compare
Note that windows build was failing prior to this PR, and is not addressed here. |
Kudos, SonarCloud Quality Gate passed! |
Will update this further - even though we can't test these older versions, there may still be cases where they get pulled in and will work (like chef-install cookbook for upgrades). After update, it will leave in 'soft' support (conditional gems by version) but remove the unsupported ruby versions. |
@marcparadise ping? :) |
Ruby 2.5 and earlier are all EOL and are no longer receiving security updates. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
pry-byebug is not supported on all platforms, and is also not necessary for running pipeline tests. Excluding gem group 'debug' from tests prevents failures related to unsupported platforms. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com> Signed-off-by: Thomas Powell <thomas.powell@progress.com>
b5d0ac2
to
5b35ff0
Compare
Kudos, SonarCloud Quality Gate passed! |
This relates to: #400 @marcparadise - I'm unclear on the status of this PR - I think we can merge, but it's been 2 years, so we should at least rebase. |
Ruby 2.5 and earlier are all EOL and are no longer receiving security updates.
Signed-off-by: Marc A. Paradise marc.paradise@gmail.com