Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch the user-data on Alibaba Cloud correctly #1802

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Fetch the user-data on Alibaba Cloud correctly #1802

merged 1 commit into from
Aug 1, 2023

Conversation

ETiV
Copy link
Contributor

@ETiV ETiV commented Jul 30, 2023

Fetch from meta-data API on Alibaba Cloud correctly by avoid fetching user-data
Previous PR: #1766

Description

On Alibaba Cloud, the response of user-data metadata API is not processed properly.
And, modified the unit tests to align with the actual response data.

Related Issue

#1765

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@ETiV ETiV requested review from a team as code owners July 30, 2023 21:17
@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ETiV ETiV mentioned this pull request Jul 30, 2023
Merged
10 tasks
@tpowell-progress tpowell-progress self-assigned this Aug 1, 2023
jaymzh
jaymzh approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming tests pass, approving.

@jaymzh jaymzh merged commit 52eb386 into chef:17-stable Aug 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaymzh jaymzh jaymzh approved these changes

Assignees

@tpowell-progress tpowell-progress

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ETiV @jaymzh @tpowell-progress