Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.2 to the list of Ruby CI versions #1804

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

igor-drozdov
Copy link
Contributor

Description

Adds 3.2 to the list of Ruby CI versions to run tests against Ruby 3.2

@igor-drozdov igor-drozdov requested review from a team as code owners August 9, 2023 04:53
@igor-drozdov igor-drozdov force-pushed the igor-drozdov-patch-1 branch 2 times, most recently from 0cb2b00 to 0d61880 Compare August 9, 2023 10:38
@tpowell-progress
Copy link
Contributor

@igor-drozdov do you only want to add runs of the unit test or exec as well? exec current only runs against 2.7 and 3.0

@tpowell-progress tpowell-progress self-assigned this Aug 9, 2023
Signed-off-by: Igor Drozdov <ihardrozdov@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@igor-drozdov
Copy link
Contributor Author

@tpowell-progress adding it to the tests seems sufficient, but adding it to both CI is more reliable. I've added the Ruby versions in both unit.yml and exec.yml, but will follow your recommendations on this one 👍

@tpowell-progress tpowell-progress merged commit 6ae004b into chef:main Aug 22, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants