Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fp/Adjusting IPROUTE_INT_REGEX to match interfaces with an underscore #1806

Conversation

fprovencherdrw
Copy link
Contributor

Description

Adjusting IPROUTE_INT_REGEX to match interfaces with an underscore and/or dash after the arobase

This would now match: 11: mgmt_team.73@mgmt_team: ...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@fprovencherdrw fprovencherdrw requested review from a team as code owners September 1, 2023 18:08
and/or underscore in it after the arobase.

This would now match: 11: mgmt_team.73@mgmt_team: ...

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the
    best of my knowledge, is covered under an appropriate open
    source license and I have the right under that license to
    submit that work with modifications, whether created in whole
    or in part by me, under the same open source license (unless
    I am permitted to submit under a different license), as
    Indicated in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including
    all personal information I submit with it, including my
    sign-off) is maintained indefinitely and may be redistributed
    consistent with this project or the open source license(s)
    involved.

Signed-off-by: Francis Provencher <fprovencher@drw.com>
@fprovencherdrw fprovencherdrw force-pushed the chore/adjust_regex_to_match_interface_with_underscore branch from 5e497dc to 3a884e2 Compare September 1, 2023 18:16
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tpowell-progress tpowell-progress merged commit 7af93d8 into chef:main Sep 5, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants