Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to 19 version for ohai and chef #1825

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Bump to 19 version for ohai and chef #1825

merged 1 commit into from
Jul 16, 2024

Conversation

tpowell-progress
Copy link
Contributor

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@tpowell-progress tpowell-progress requested review from a team as code owners July 2, 2024 17:28
sean-simmons-progress
sean-simmons-progress approved these changes Jul 11, 2024
View reviewed changes
Copy link

@sean-simmons-progress sean-simmons-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only concern I have here is that we are manually changing the version?

@tpowell-progress tpowell-progress added the Expeditor: Bump Version Major Used by github.major_bump_labels to bump the Major version number. label Jul 16, 2024
@tpowell-progress
Bump chef-config/utils upper bounds to < 20
26d9402 
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tpowell-progress tpowell-progress merged commit 3a4e583 into main Jul 16, 2024
30 of 31 checks passed
@tpowell-progress tpowell-progress deleted the tp/bump-to-19 branch July 16, 2024 13:24
tpowell-progress added a commit that referenced this pull request Jul 16, 2024
@tpowell-progress
Revert "Bump chef-config/utils upper bounds to < 20 (#1825)"
e5233ba 
This reverts commit 3a4e583.
@tpowell-progress tpowell-progress mentioned this pull request Jul 16, 2024
Closed
@sonarqube-for-infrastructure-prod SonarQube for Infrastructure (Prod)
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-simmons-progress sean-simmons-progress sean-simmons-progress approved these changes

@neha-p6 neha-p6 neha-p6 approved these changes

@johnmccrae johnmccrae johnmccrae approved these changes

Assignees
No one assigned
Labels
Expeditor: Bump Version Major Used by github.major_bump_labels to bump the Major version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tpowell-progress @johnmccrae @neha-p6 @sean-simmons-progress