Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test with arbitrary #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add test with arbitrary #5

wants to merge 1 commit into from

Conversation

da-x
Copy link
Contributor

@da-x da-x commented Sep 5, 2021

The test from #4 can be made accessible with -

cargo test --all-features

This PR adds the test.
It still fails, however.

@chinedufn
Copy link
Owner

Some questions:

  • How fast/slow are these tests?

  • Do you have any examples of how other libraries make use of quickcheck + arbitrary? i.e. do they run it in CI, or do they just keep it behind a feature flag?

  • Would you recommend that these run in CI?

  • How do you see this evolving over time? What would a good arbitrary-based test suite look like? Are there more tests that you would want to see added over time?

  • Do you know how/why this arbitrary test fails?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants