Added raw packets for realtime encode/decode

[dioptre]

No description provided.

[chris-rudmin]

@dioptre Thanks for the pull request. Just curious what is the use case for opus encoded audio without a container?
If you would like this to be merged, could you add documentation, and unit tests for your code changes?

[dioptre]

Fast efficient real-time streaming working like a charm.

I don't have time to write unit tests this week.

Thanks
Andrew

[MrdUkk]

just my 2 cents.
Im interested in raw encoded frames from opus too. without overhead. currently proposed patch is wrong.

encoderWorker.min.js:1 Uncaught ReferenceError: postMessage is not defined
at OggOpusEncoder.segmentPacket (encoderWorker.min.js:1)
at OggOpusEncoder.encode (encoderWorker.min.js:1)
at AudioWorkletProcessor.process (encoderWorker.min.js:1)

i think in segmentPacket function you can't invoke postMessage(). need change upper IF to
var exportPages = [];
if (this.config.rawPacket) {
if (packetLength > 0) {
var page = new Uint8Array( HEAPU8.subarray(this.encoderOutputPointer, this.encoderOutputPointer + packetLength) );
exportPages.push(page);
this.framesInPage = 0;
return;
}
}

be aware that inrementing framesInPage variable without resetting will lead to overflow. so i added reset

[MrdUkk]

digging little deeper in source i found better (and working!) solution. (I need RAW opus frames. each frame is distinct byteArray element inserted into another byteArray)

patching needed only in 3 functions: encode, flush, encodeFinalFrame (encoderWorker.js). This won't touch 'hot' path functions that deal with Ogg packing.
Now I don’t understand which is more correct: pull another request with changed file or simply put here changed lines from original source?

[pitonoved]

digging little deeper in source i found better (and working!) solution. (I need RAW opus frames. each frame is distinct byteArray element inserted into another byteArray)

patching needed only in 3 functions: encode, flush, encodeFinalFrame (encoderWorker.js). This won't touch 'hot' path functions that deal with Ogg packing.
Now I don’t understand which is more correct: pull another request with changed file or simply put here changed lines from original source?

I need this solution too..

[MrdUkk]

@pitonoved

I need this solution too..

how we would contact?
Original Author does not communicate what should i do (post here changed lines in original code or pull another request)

[dioptre]

The solution you have is good but doesn't work with decoding ogg frames, so how about you add encodeRaw etc.

…

On Wed, Feb 10, 2021, 02:21 dUkk ***@***.***> wrote: @pitonoved <https://github.com/pitonoved> I need this solution too.. how we would contact? Original Author does not communicate what should i do (post here changed lines in original code or pull another request) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#221 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFZTGFH4FEWCILXJTWUCHDS6JM2XANCNFSM4SL4DXYA> .

[WindowsNT]

Do we still have this solution?