kprobe: attach kprobe / kretprobe based on the SectionName #1508
+69
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhuhuijun zhuhuijunzhj@gmail.com
|
Hi, sorry for the slow response. I'm a little confused by this patch. What problem does it solve? You've added some code that relies on ProgramInfo.Name (which gets truncated to 20 characters), but I'm not sure why. May I assume you want to 'fix' the issue by documenting it as an example? I think the library can do more to be more helpful, but on the other hand, this all feels like a bit of a non-issue to me. There's nothing that semantically differentiates a kprobe from a kretprobe program, so trying to prevent the user from attaching something to the 'wrong' hook feels a bit counterproductive. @lmb WDYT as you initially created the issue. Do you have more context about the situation this popped up in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #1497