-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qa #45
Conversation
Hello @stroblme! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-11-15 12:45:51 UTC |
Just thought it would have been smarter to first address #38 , because flake now complains a lot.. well know what to do now.. |
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
checks failing because of cirKITers/qml-essentials/pull/62 . Would suggest to merge as licensecheck issues are being resolved when upgrading qml essentials |
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the missing elements in the side bar, it looks good. Thanks for the great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved sidebar pages back to app
This PR resolves #41 and resolves #38
Depends on #44