Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qa #45

Merged
merged 9 commits into from
Nov 15, 2024
Merged

Qa #45

merged 9 commits into from
Nov 15, 2024

Conversation

stroblme
Copy link
Member

@stroblme stroblme commented Nov 11, 2024

This PR resolves #41 and resolves #38

Depends on #44

Signed-off-by: Melvin Strobl <lc3267@kit.edu>
@pep8speaks
Copy link

pep8speaks commented Nov 11, 2024

Hello @stroblme! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 21:89: E501 line too long (89 > 88 characters)

Line 21:89: E501 line too long (125 > 88 characters)
Line 22:89: E501 line too long (122 > 88 characters)
Line 28:89: E501 line too long (89 > 88 characters)
Line 30:89: E501 line too long (125 > 88 characters)
Line 31:89: E501 line too long (126 > 88 characters)
Line 32:89: E501 line too long (110 > 88 characters)
Line 33:89: E501 line too long (128 > 88 characters)
Line 36:89: E501 line too long (126 > 88 characters)
Line 37:89: E501 line too long (124 > 88 characters)
Line 40:89: E501 line too long (129 > 88 characters)
Line 41:89: E501 line too long (122 > 88 characters)
Line 42:89: E501 line too long (122 > 88 characters)
Line 43:89: E501 line too long (116 > 88 characters)
Line 44:89: E501 line too long (105 > 88 characters)
Line 46:89: E501 line too long (90 > 88 characters)
Line 51:89: E501 line too long (92 > 88 characters)
Line 78:89: E501 line too long (90 > 88 characters)
Line 84:89: E501 line too long (94 > 88 characters)
Line 92:89: E501 line too long (122 > 88 characters)
Line 93:89: E501 line too long (122 > 88 characters)
Line 94:89: E501 line too long (125 > 88 characters)
Line 95:89: E501 line too long (125 > 88 characters)
Line 96:89: E501 line too long (124 > 88 characters)
Line 109:89: E501 line too long (94 > 88 characters)
Line 119:89: E501 line too long (125 > 88 characters)
Line 122:89: E501 line too long (123 > 88 characters)
Line 135:89: E501 line too long (94 > 88 characters)

Line 66:89: E501 line too long (92 > 88 characters)
Line 106:89: E501 line too long (89 > 88 characters)
Line 131:89: E501 line too long (94 > 88 characters)
Line 160:89: E501 line too long (94 > 88 characters)
Line 189:89: E501 line too long (97 > 88 characters)

Comment last updated at 2024-11-15 12:45:51 UTC

qa
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
@stroblme
Copy link
Member Author

Just thought it would have been smarter to first address #38 , because flake now complains a lot.. well know what to do now..

@stroblme stroblme marked this pull request as draft November 11, 2024 14:44
@stroblme stroblme mentioned this pull request Nov 11, 2024
Melvin Strobl added 3 commits November 14, 2024 08:41
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
@stroblme
Copy link
Member Author

stroblme commented Nov 14, 2024

checks failing because of cirKITers/qml-essentials/pull/62 . Would suggest to merge as licensecheck issues are being resolved when upgrading qml essentials

@stroblme stroblme marked this pull request as ready for review November 14, 2024 07:58
@stroblme stroblme requested a review from majafranz November 14, 2024 07:58
Melvin Strobl added 3 commits November 14, 2024 14:34
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
gc
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
@stroblme stroblme mentioned this pull request Nov 14, 2024
app/app.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@majafranz majafranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the missing elements in the side bar, it looks good. Thanks for the great work!

Copy link
Collaborator

@majafranz majafranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved sidebar pages back to app

@majafranz majafranz merged commit db6cacd into main Nov 15, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Add QA [FR] Export HTML code to external files and add #NOQA for those
3 participants