Trying to allow circus-web to run under Python 3 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torandio2 is no longer maintained, so Python 3.0 is not been added. This means that circus-web doesn't work under (see Issue circus-tent#43). From the torandio2 README.rst > Unfortunately, Socket.IO 0.8 branch is abandoned, there are huge amount of > bugs and nothing getting fixed. I would suggest to look at alternative > options, for example SockJS <http://github.com/sockjs/>. There's > sockjs-tornado <http://github.com/mrjoes/sockjs-tornado/> too. I don't plan > to support TornadIO2 anymore, assuming that parent library is no longer > maintained. Following the example provided by seesaw-kit ArchiveTeam/seesaw-kit#40
|
Friendly poke.... Could use some guidance on if this is going in a direction which would be mergeable. |
|
This is about getting 3.3+ support right? The PR seems to suggest all of the 3.x series... |
|
"Python 3" support - no idea which version is a minimum requirement. |
mithro
changed the title
|
I think you can target 3.3 or 3.4 as Python 3 developpers will keep up with the last version. |
|
I added few more commits against current master - #60 |
|
@mithro can you try current master and see if it works for you? |
|
sockjs-tornado seems to be in active development so IMHO moving away from abandoned tornadIO2 is a good idea. |
|
It is unlikely I'll get a chance to try this any time soon. The project
where I'm using circus is currently not a high priority.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the following issue for more context: #43
torandio2 is no longer maintained, so circus-web has been ported to SockJs.Torando.
All the tests seem to fail without any of my changes, see #44 thus I can't test if this change actually works or not...
The rest of circus seems to work fine under Python 3, so its just circus-web which is holding back full Python 3 support?